Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #889

Merged
merged 16 commits into from
Jan 1, 2024
Merged

Update README.md #889

merged 16 commits into from
Jan 1, 2024

Conversation

edenlum
Copy link
Contributor

@edenlum edenlum commented Dec 20, 2023

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@edenlum edenlum requested a review from Idan-BenAmi December 27, 2023 10:37
tutorials/quick_start/README.md Outdated Show resolved Hide resolved
@Idan-BenAmi
Copy link
Collaborator

Idan-BenAmi commented Dec 31, 2023

I would locate the notebook file under notebooks folder with informative name and update the link from the table,

@edenlum edenlum merged commit 70df2e6 into main Jan 1, 2024
24 checks passed
@edenlum edenlum deleted the quickstart-table branch January 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants