Merge pull request #135 from sonroyaalmerol/update-error

add error logs for database update errors
sonroyaalmerol · Feb 7, 2025 · 0577f7c · 0577f7c
2 parents 3fd299f + a658c79
commit 0577f7c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/cmd/pbs_plus/main.go b/cmd/pbs_plus/main.go
@@ -82,7 +82,10 @@ func main() {
 				jobTask.LastRunPlusError = err.Error()
 				jobTask.LastRunPlusTime = int(time.Now().Unix())
 
-				_ = storeInstance.Database.UpdateJob(*jobTask)
+				uErr := storeInstance.Database.UpdateJob(*jobTask)
+				if uErr != nil {
+					syslog.L.Errorf("LastRunPlusError update: %v", uErr)
+				}
 			}
 			syslog.L.Error(err)
 			return

diff --git a/internal/proxy/controllers/jobs/jobs.go b/internal/proxy/controllers/jobs/jobs.go
@@ -12,6 +12,7 @@ import (
 	"github.com/sonroyaalmerol/pbs-plus/internal/proxy/controllers"
 	"github.com/sonroyaalmerol/pbs-plus/internal/store"
 	"github.com/sonroyaalmerol/pbs-plus/internal/store/types"
+	"github.com/sonroyaalmerol/pbs-plus/internal/syslog"
 	"github.com/sonroyaalmerol/pbs-plus/internal/utils"
 )
 
@@ -64,7 +65,10 @@ func ExtJsJobRunHandler(storeInstance *store.Store) http.HandlerFunc {
 				job.LastRunPlusError = err.Error()
 				job.LastRunPlusTime = int(time.Now().Unix())
 
-				_ = storeInstance.Database.UpdateJob(*job)
+				uErr := storeInstance.Database.UpdateJob(*job)
+				if uErr != nil {
+					syslog.L.Errorf("LastRunPlusError update: %v", uErr)
+				}
 			}
 
 			controllers.WriteErrorResponse(w, err)