Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make smart switch HA detailed design doc less ambiguous #1873

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

erer1243
Copy link

@erer1243 erer1243 commented Dec 18, 2024

  1. fixed a weird artifact of the mermaid graph where arrows were overlapping
  2. Change all instances of empty string value to none to make remove ambiguity of "" being an empty list or a single element list of the element "". It may make sense for some of these to be called auto or default instead - eg outbound_eni_mac_lookup. Let me know your thoughts.
  3. Make some field names more consistent

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

@erer1243 erer1243 requested a review from r12f January 17, 2025 16:23
remove underscore from pending_operation_types values

add _in_ms to pending_operation_list_last_updated_time_in_ms
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants