[BG-163]: swagger 세팅 (2.5h / 4h) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
security config에 swagger 설정 추가
Dltmd202
reviewed
Jul 1, 2024
| import io.swagger.v3.oas.annotations.media.Schema | ||
|
|
||
| data class JwtTokenResponse( | ||
| @Schema( |
There was a problem hiding this comment.
dto도 swagger 관련된 부분 interface로 뺄 수 없을까??
There was a problem hiding this comment.
Response로 되어 있는 부분은 전부 controller 영역에서만 호출하게 해놔서
Interface로 빼게 되면 너무 과하지 않을까 싶은데..
어떻게 생각해?
| .description("Api Documentation") | ||
|
|
||
| return OpenAPI() | ||
| .addServersItem(Server().url("http://localhost:8080").description("Local Server")) |
| ServletUriComponentsBuilder | ||
| .fromCurrentRequest() | ||
| .path("/{id}") | ||
| .buildAndExpand(workspaceFacadeService.createWorkspace(token.id, request.toDto())) |
There was a problem hiding this comment.
이게 Location 헤더에 해당 URI 넣어주려고 하는거지??
근데 workspaceFacadeService.createWorkspace(token.id, request.toDto()) 이 결과가 Long 으로 반환되고 있지 않은 것 같아!
There was a problem hiding this comment.
그렇네 pr pull 하는 과정에서 바뀌었넹
👍 좋아용~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
swagger 설정을 추가함
How
swagger 설정을 비즈니스 로직에서 안들어내기 위해
Interface 및 Request, Response를 활용함
Result
테스트 변경 사항 없음
Link
BG-163