Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BG-391]: reaction 채팅 생성 구현 (1.5h / 2.0h) #109

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

GGHDMS
Copy link
Member

@GGHDMS GGHDMS commented Sep 2, 2024

Why

reply 이벤트 생성과 로직이 유사해서 빨리 끝났다

How

현재 Reaction Entity는 단지 Event의 아이디만 가지고 있는 구조이다
optionevent의 id를 바로 사용하는 것이 부자연스럽다고 생각해서
이렇게 했는데 고민해 봐야 될듯

Link

BG-391

@GGHDMS GGHDMS requested a review from Dltmd202 September 2, 2024 12:44
@GGHDMS GGHDMS self-assigned this Sep 2, 2024
Copy link
Member

@Dltmd202 Dltmd202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구욷~

@GGHDMS
Copy link
Member Author

GGHDMS commented Sep 2, 2024

ㅋㅋ 코드 봤니?

@GGHDMS GGHDMS merged commit e5945b9 into develop Sep 2, 2024
1 check passed
@GGHDMS GGHDMS deleted the feature/BG-391-reaction-create branch September 2, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants