This repository has been archived by the owner on Sep 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Peter O'Connor <[email protected]>
- Loading branch information
Peter O'Connor
committed
Jul 16, 2018
1 parent
209af77
commit a54f6e7
Showing
3 changed files
with
158 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| From e58d64a16abc2304c4dcb644411eb9580bf63b1e Mon Sep 17 00:00:00 2001 | ||
| From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= <[email protected]> | ||
| Date: Tue, 15 May 2018 17:30:39 +0200 | ||
| Subject: [PATCH] ccid-card-passthru: fix regression in realize() | ||
| MIME-Version: 1.0 | ||
| Content-Type: text/plain; charset=UTF-8 | ||
| Content-Transfer-Encoding: 8bit | ||
|
|
||
| Since cc847bfd16d894fd8c1a2ce25f31772f6cdbbc74, CCID card-passthru | ||
| fails to intialize, because it changed a debug line to an error, | ||
| probably by mistake. Change it back to a DPRINTF debug. | ||
|
|
||
| (solves Boxes creating VM with smartcard passthru failing to start) | ||
|
|
||
| Signed-off-by: Marc-André Lureau <[email protected]> | ||
| Reviewed-by: Philippe Mathieu-Daudé <[email protected]> | ||
| Message-id: [email protected] | ||
| Signed-off-by: Gerd Hoffmann <[email protected]> | ||
| --- | ||
| hw/usb/ccid-card-passthru.c | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c | ||
| index 7684db0cb37..25fb19b0d71 100644 | ||
| --- a/hw/usb/ccid-card-passthru.c | ||
| +++ b/hw/usb/ccid-card-passthru.c | ||
| @@ -345,7 +345,7 @@ static void passthru_realize(CCIDCardState *base, Error **errp) | ||
| card->vscard_in_pos = 0; | ||
| card->vscard_in_hdr = 0; | ||
| if (qemu_chr_fe_backend_connected(&card->cs)) { | ||
| - error_setg(errp, "ccid-card-passthru: initing chardev"); | ||
| + DPRINTF(card, D_INFO, "ccid-card-passthru: initing chardev"); | ||
| qemu_chr_fe_set_handlers(&card->cs, | ||
| ccid_card_vscard_can_read, | ||
| ccid_card_vscard_read, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters