Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-92688: refactor extconf #163

Merged
merged 2 commits into from
Oct 25, 2024
Merged

NH-92688: refactor extconf #163

merged 2 commits into from
Oct 25, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

Description

reduce to OBOE_ENV and OBOE_DEBUG

Test (if applicable)

@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner October 1, 2024 15:23
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending comment!

@@ -18,27 +18,34 @@
init_mkmf(CONFIG)

ext_dir = __dir__
oboe_debug = ENV['OBOE_DEBUG'].to_s.casecmp('true').zero?
non_production = ENV['OBOE_DEV'].to_s.casecmp('true').zero? || ENV['OBOE_STAGING'].to_s.casecmp('true').zero?
ENV['OBOE_DEBUG'].to_s.casecmp('true').zero?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the above line needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cheempz cheempz merged commit 515833a into main Oct 25, 2024
14 checks passed
@cheempz cheempz deleted the NH-92688 branch October 25, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants