-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-89406: improve control for building debug version of the extension and added documentation #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xuan-cao-swi! This is really great info, much appreciated. I left a bunch of comments based on understanding below (which may be wrong):
- in order to get extended info out of coredump, the crash needs to be reproduced using special version of solarwinds_apm
- this special version can be achieved purely at install time by setting env var
OBOE_DEBUG
which enables more info in the c-extension binding code AND uses a version of liboboe that comes with extended debug info.
puts 'Fetching finished.' | ||
end | ||
|
||
def fetch_file_from_cloud(files, oboe_dir, dest_dir, folder = '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice DRYing :)
Co-authored-by: Lin Lin <[email protected]>
Co-authored-by: Lin Lin <[email protected]>
Co-authored-by: Lin Lin <[email protected]>
For now yes, here is the difference log info
Yes, and also need the liboboe build with ReleaseAndDebug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! really appreciate the revisits and added tests @xuan-cao-swi. We'll need to bump the liboboe version to 15.0.2 for debug install to work, but feel free to put that in as part of the main release prep.
Description
OBOE_DEBUG
,OBOE_DEV
,OBOE_STAGING
appears. The test case require deep stub on each different function to avoid c lib dependency.OBOE_DEBUG
will make the fetch of production release with relwithdebug directly.Test (if applicable)