Merge pull request #83 from solarwindscloud/NH-62724

NH-62724: update secrets for github_action
solarwinds · Oct 13, 2023 · d7ff935 · d7ff935
2 parents 65dc1b4 + 5d21665
commit d7ff935
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/.github/workflows/build_and_release_gem.yml b/.github/workflows/build_and_release_gem.yml
@@ -6,7 +6,6 @@ name: Ruby Gem to RubyGems
 # - TRACE_BUILD_RUBY_ACTIONS_API_TOKEN (from the trace-build user in github)
 # - RUBYGEMS_TOKEN (from the solarwinds-apm user on rubygems.org)
 # - APM_RUBY_INSTALL_TESTING_SWO_KEY
-# - CI_GITHUB_TOKEN
 #
 # The correct oboe version has to be in the file ext/oboe_metal/src/VERSION
 
@@ -75,7 +74,7 @@ jobs:
       - name: Create release draft that includes the checksum
         uses: actions/github-script@v3
         with:
-          github-token: ${{secrets.CI_GITHUB_TOKEN}}
+          github-token: ${{secrets.GITHUB_TOKEN}}
           script: |
             github.repos.createRelease({
               owner: "solarwindscloud",

diff --git a/.github/workflows/verify_install.yml b/.github/workflows/verify_install.yml
@@ -31,6 +31,12 @@ jobs:
       matrix: ${{ steps.launch.outputs.matrix }} # this will be a json object mapping identifiers to labels and instance ids
     runs-on: ubuntu-latest
     steps:
+      - uses: getsentry/action-github-app-token@v2
+        id: github-token
+        with:
+          app_id: ${{ vars.APPLICATION_ID }}
+          private_key: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+
       - uses: aws-actions/configure-aws-credentials@v2
         with:
           aws-access-key-id: ${{ secrets.CI_ACCESS_KEY_ID }}
@@ -49,7 +55,7 @@ jobs:
             amazonlinux:2
             amazonlinux:2023
             ubuntu:22.04
-          github-token: ${{ secrets.CI_GITHUB_TOKEN }}
+          github-token: ${{ steps.github-token.outputs.token }}
           runner-user: github
           runner-directory: /gh
           instance-type: t4g.medium
@@ -121,6 +127,12 @@ jobs:
       - verify_installation
     runs-on: ubuntu-latest
     steps:
+      - uses: getsentry/action-github-app-token@v2
+        id: github-token
+        with:
+          app_id: ${{ vars.APPLICATION_ID }}
+          private_key: ${{ secrets.APPLICATION_PRIVATE_KEY }}
+
       - uses: aws-actions/configure-aws-credentials@v2
         with:
           aws-access-key-id: ${{ secrets.CI_ACCESS_KEY_ID }}
@@ -129,5 +141,5 @@ jobs:
       - uses: solarwindscloud/ec2-runner-action@main
         with:
           action: terminate
-          github-token: ${{ secrets.CI_GITHUB_TOKEN }}
+          github-token: ${{ steps.github-token.outputs.token }}
           matrix: ${{ needs.start_arm64_runner.outputs.matrix }} # passing a matrix will terminate all runners, not just one