Fix resource leak for HttpClient-based backends on cancellation #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioaoue
reviewed
Jan 23, 2025
|
|
||
| override protected def ensureOnAbnormal[T](effect: Task[T])(finalizer: => Task[Unit]): Task[T] = effect.onExit { | ||
| exit => | ||
| if (exit.isSuccess) ZIO.unit else finalizer.orDie |
There was a problem hiding this comment.
I'm not sure if it's correct to use .orDie here. I don't think users will expect that sending a request might result in a defect. Defects are often considered unrecoverable and propagate until some higher-level handler catches them, and in some cases can cause the entire application to crash. Maybe in this case it would be better to just ignore the error?
There was a problem hiding this comment.
There's a .resurrect later on, but yeah, maybe ignoring here is fine
There was a problem hiding this comment.
Oh, sorry, I somehow didn't notice the .resurrect call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1987