Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Entity Component to Entities via EntityInspectorView #295

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

softwareantics
Copy link
Owner

Description

Please include a summary of your changes along with relevant motivation and context.

Fixes # (issue)

Dependencies

Please list any dependencies that are required for this change.

Type of change

Please delete any irrelevant changes.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Other (please specify).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Operating System:
  • Hardware:
  • Toolchain:

Proposed Design

If this PR introduces new functionality that can be considered as somewhat complex or it introduces new interfaces without implementations please give a detailed overview of how it works, when to use it and any other additional information.

Pseudo Code

If this PR does introduce complexities or new interfaces it is advised to provide some example code to showcase it's use here.

Possible Issues

Please list any possible issues that may arise from the merge of this PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@softwareantics softwareantics added ✨ Feature Additional functionality that has not been implemented. 🔴 High Priority High priority area-ecs ECS related tasks area-editor Editor related tasks labels Dec 3, 2023
@softwareantics softwareantics self-assigned this Dec 3, 2023
Copy link
Owner Author

@softwareantics softwareantics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, rename typeReciever to typeResolver where required.

@softwareantics softwareantics marked this pull request as ready for review December 5, 2023 14:07
@softwareantics softwareantics merged commit c2bb7ba into master Dec 5, 2023
17 of 18 checks passed
@softwareantics softwareantics deleted the feature/292 branch December 5, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ecs ECS related tasks area-editor Editor related tasks ✨ Feature Additional functionality that has not been implemented. 🔴 High Priority High priority
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant