-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Entity Component to Entities via EntityInspectorView
#295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwareantics
added
✨ Feature
Additional functionality that has not been implemented.
🔴 High Priority
High priority
area-ecs
ECS related tasks
area-editor
Editor related tasks
labels
Dec 3, 2023
softwareantics
commented
Dec 4, 2023
softwareantics
commented
Dec 4, 2023
softwareantics
commented
Dec 4, 2023
FinalEngine.Editor.ViewModels/Inspectors/EntityComponentCategoryViewModel.cs
Outdated
Show resolved
Hide resolved
softwareantics
commented
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, rename typeReciever
to typeResolver
where required.
FinalEngine.Editor.ViewModels/Inspectors/EntityComponentCategoryViewModel.cs
Outdated
Show resolved
Hide resolved
FinalEngine.Editor.ViewModels/Inspectors/EntityComponentTypeViewModel.cs
Outdated
Show resolved
Hide resolved
FinalEngine.Editor.ViewModels/Inspectors/EntityComponentTypeViewModel.cs
Outdated
Show resolved
Hide resolved
FinalEngine.Editor.ViewModels/Inspectors/EntityComponentTypeViewModel.cs
Outdated
Show resolved
Hide resolved
FinalEngine.Editor.ViewModels/Inspectors/EntityComponentTypeViewModel.cs
Show resolved
Hide resolved
FinalEngine.Editor.ViewModels/Inspectors/EntityInspectorViewModel.cs
Outdated
Show resolved
Hide resolved
FinalEngine.Editor.ViewModels/Inspectors/EntityInspectorViewModel.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-ecs
ECS related tasks
area-editor
Editor related tasks
✨ Feature
Additional functionality that has not been implemented.
🔴 High Priority
High priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of your changes along with relevant motivation and context.
Fixes # (issue)
Dependencies
Please list any dependencies that are required for this change.
Type of change
Please delete any irrelevant changes.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Proposed Design
If this PR introduces new functionality that can be considered as somewhat complex or it introduces new interfaces without implementations please give a detailed overview of how it works, when to use it and any other additional information.
Pseudo Code
If this PR does introduce complexities or new interfaces it is advised to provide some example code to showcase it's use here.
Possible Issues
Please list any possible issues that may arise from the merge of this PR.
Checklist: