-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop benchmarks #951
base: master
Are you sure you want to change the base?
Develop benchmarks #951
Conversation
I am wondering what kind of resolution presets use to be meaningful and unambiguous. Maybe rename it to sth like pub enum ResolutionPreset {
Uhd,
Qhd,
Fhd,
Hd,
Sd,
} |
pub encoder_preset: EncoderPreset, | ||
pub disable_encoder: bool, | ||
|
||
#[arg(long, global = true, required_unless_present("disable_encoder"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need global
here, as we don't have subcommands.
Also, you can use default_value
instead of Option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think default_value
changes much here, it's not used anyway if disable_encoder
is present. Talking about defaults, I would highly consider adding default values to all parameters, so you don't need to specify all of them every time what is a bit inconvenient
PR for issue #937
Develop more benchmark options:
resolution
outputs
run without encoder
run without decoder
renamed
encoder/decoder_count
tooutput/input_count
to be more meaningful