Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to ContainerDetails #266

Closed
wants to merge 4 commits into from
Closed

Add missing fields to ContainerDetails #266

wants to merge 4 commits into from

Conversation

vv9k
Copy link
Contributor

@vv9k vv9k commented Feb 10, 2021

What did you implement:

Added missing fields to ContainerDetails and reordered them to resemble the same order as docker api reference.

Closes: #202
Closes: #172

How did you verify your change:

Tested locally.

What (if anything) would need to be called out in the CHANGELOG for the next release:

  • ContainerDetails now contains all fields available in docker.
  • HostConfig.port_bindings inner elements now have a clear type PortBinding instead of HashMap<String, String>
  • Config is now renamed to ContainerConfig

@vv9k
Copy link
Contributor Author

vv9k commented Mar 11, 2021

Rebased to current master, I guess ready to merge if there are no suggestions.

@matthiasbeyer
Copy link
Collaborator

Hm. Generally this looks good IMO, but is there a way to add automated (or manual) tests for this? Like... an example that one can execute to see the data points added in the API here?

@vv9k vv9k closed this Jun 29, 2021
@matthiasbeyer matthiasbeyer mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing fields in the result of inspect clearly typed ContainerDetails.
2 participants