Add missing fields to ContainerDetails #266
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Added missing fields to
ContainerDetails
and reordered them to resemble the same order as docker api reference.Closes: #202
Closes: #172
How did you verify your change:
Tested locally.
What (if anything) would need to be called out in the CHANGELOG for the next release:
ContainerDetails
now contains all fields available in docker.HostConfig.port_bindings
inner elements now have a clear typePortBinding
instead ofHashMap<String, String>
Config
is now renamed toContainerConfig