[Refactor] 차량 소개, 선착순 이벤트, 인증 모달 관련 테스트 코드 작성 및 리팩토링 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leve68
approved these changes
Aug 19, 2024
Comment on lines
+44
to
+55
| await Promise.all( | ||
| glowElemntArray.map((glowElemnt, index) => { | ||
| expect(glowElemnt.animate).toHaveBeenCalledWith(fadeIn, { | ||
| ...glowFadeOptions, | ||
| delay: (index + 1) * 1000, | ||
| }); | ||
| }), | ||
| ); | ||
|
|
||
| glowElemntArray.map((glowElemnt) => { | ||
| expect(glowElemnt.animate).toHaveBeenCalledWith(randomGlow, glowOptions); | ||
| }); |
There was a problem hiding this comment.
저는 훅 자체를 그냥 목 으로 사용했는데 이렇게 하면 구체적으로 어떤 애니메이션을 호출해서 실행했는지까지도 테스트 할 수 있겠네요
Comment on lines
+11
to
+32
| describe("ConvenienceDescriptionItem 렌더링 테스트", () => { | ||
| test("props로 전달받은 제목이 렌더링 되야 한다.", () => { | ||
| render(<ConvenienceDescriptionItem {...defaultProps} />); | ||
|
|
||
| const title = screen.getByText(defaultProps.title); | ||
| expect(title).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test("props로 전달받은 설명이 렌더링 되야 한다.", () => { | ||
| render(<ConvenienceDescriptionItem {...defaultProps} />); | ||
|
|
||
| const description = screen.getByText(defaultProps.description); | ||
| expect(description).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test("props로 전달받은 이미지가 렌더링 되야 한다.", () => { | ||
| render(<ConvenienceDescriptionItem {...defaultProps} />); | ||
|
|
||
| const image = screen.getByRole("img"); | ||
| expect(image).toHaveAttribute("src", defaultProps.img); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
저는 props 에 따른 랜더링테스트 test 하나에서 전부 했는데 랜더링 테스트를 분리해서 하나의 describe 에 넣는 방식도 좋은 것 같아요
Comment on lines
+6
to
+20
| IntersectionObserver = jest.fn().mockImplementation((callback) => { | ||
| return { | ||
| observe: jest.fn((element) => { | ||
| callback([ | ||
| { | ||
| isIntersecting: false, | ||
| target: element, | ||
| intersectionRect: { top: 0, left: 0 }, | ||
| }, | ||
| ]); | ||
| }), | ||
| unobserve: jest.fn(), | ||
| disconnect: jest.fn(), | ||
| }; | ||
| }); |
There was a problem hiding this comment.
IntersectionObserver를 이렇게 테스트 할 수 있군요... 신기해요
Comment on lines
+46
to
+51
| act(() => { | ||
| (IntersectionObserver as jest.Mock).mock.calls[0][0]([ | ||
| { isIntersecting: true }, | ||
| ]); | ||
| }); | ||
|
|
There was a problem hiding this comment.
콜백 호출 테스트를 이런식으로 해야 하는군요
복잡하네요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 이슈 번호
💡 작업 내용
💡 자세한 설명
테스트 코드 작성
📗 참고 자료 (선택)
jest mocking
jest mock, spyon
📢 리뷰 요구 사항 (선택)
🚩 후속 작업 (선택)
✅ 셀프 체크리스트