[Feature] 파일 S3 업로드 추가, 필터에서 Multipart 데이터를 받기 위한 ServletRequest Wrapping #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 요청 dto에서 이미지 경로가 아닌 파일 업로드
- 요청 dto에서 이미지 경로가 아닌 파일 업로드
- ServletRequestMapper의 ServletRequest 구현체(Request.class) 메서드 오버라이딩 - content 파싱하여 로깅
luna156
reviewed
Aug 22, 2024
Comment on lines
13
to
17
| /** | ||
| * 일반적인 Json Body를 로깅하기 위해서 Mdc에 저장하는 필터 | ||
| */ | ||
| public class RequestMultipartBodyCollectionFilter extends OncePerRequestFilter { | ||
|
|
luna156
reviewed
Aug 22, 2024
Comment on lines
181
to
189
| outer: | ||
| for (int i=start; i<=data.length-pattern.length; i++) { | ||
| for (int j=0; j<pattern.length; j++) { | ||
| if (data[i+j] != pattern[j]) | ||
| continue outer; | ||
| } | ||
| return i; | ||
| } | ||
| return -1; |
There was a problem hiding this comment.
와 continue나 break에 라벨을 붙일수도 있군요
There was a problem hiding this comment.
goto를 권장하지 않고있어서 저는 이런식으로 하는데, 더 좋은 방법 알고계시면 알려주시면 감사합니다
luna156
approved these changes
Aug 22, 2024
- 주석 추가/수정 - 상수 분리
|
많이 복잡한 작업이었는데 정말 많이 도와주셔서 훨씬 빠르게 할 수 있었던 것 같습니다. 감사합니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 이슈 번호
Issue #52
💡 작업 내용
💡 자세한 설명
과정
-> 정리해서 추가하겠습니다
-> 주석으로 추가했습니다.
-> json과 multipart 잘 들어가고, 로그 잘 남습니다.
-> s3 업로드 잘 됩니다.
📗 참고 자료
https://coderanch.com/t/781674/open-source/apache-common-FileUpload
https://stackoverflow.com/questions/68478443/converting-multipartfile-to-file
https://commons.apache.org/proper/commons-fileupload/overview.html
https://stackoverflow.com/questions/48255058/how-to-check-if-httpservletrequest-getpart-is-set-or-not
✅ 셀프 체크리스트