[refactor] 헤더바 개선 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lybell-art
reviewed
Jul 31, 2024
Comment on lines
+5
to
+6
| const ITEM_WIDTH = 96; // w-24 | ||
| const ITEM_GAP = 32; // gap-8 |
There was a problem hiding this comment.
매직넘버를 상수로 관리하는 거 좋습니다:)
src/header/index.jsx
Outdated
Comment on lines
37
to
42
| let newPositionList = []; | ||
| for (let i = 0; i < scrollSectionList.length; i++) { | ||
| newPositionList[i] = ITEM_WIDTH / 4 + i * (ITEM_WIDTH + ITEM_GAP); | ||
| } | ||
|
|
||
| const position = Math.floor(newPositionList[scrollState]); |
There was a problem hiding this comment.
newPositionList[scrollState]만 실제로 사용하고 있는데, 그렇다면 굳이 배열까지 필요하지 않아도 되지 않을까요?
lybell-art
approved these changes
Jul 31, 2024
Comment on lines
+38
to
+40
| const position = Math.floor( | ||
| ITEM_WIDTH / 4 + scrollState * (ITEM_WIDTH + ITEM_GAP), | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용