Fix dask COUNT queries on windows
#2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the dask cursor that would cause it to return `None` instead of `0` when performing a COUNT() query on Windows. `dask-sql` returns an empty data frame when there are no matches. This is normally translated to 0 in the DaskCursor class when using fetchone with a numeric result. Unfortunately the logic to detect a numeric result did not behave correctly on Windows. The dtype used is int64, which on linux appears to compare equal to int but does not compare equal on Windows. This commit uses `np.issubdtype` to have a more robust check for integer types.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue in the dask cursor that would cause it to return
Noneinstead of0when performing a COUNT() query on Windows.dask-sqlreturns an empty data frame when there are no matches. This is normally translated to 0 in theDaskCursorclass when using fetchone with a numeric result.Unfortunately the logic to detect a numeric result did not behave correctly on Windows. The dtype used is int64, which on linux appears to compare equal to int but does not compare equal on Windows.
This commit uses
np.issubdtypeto have a more robust check for integer types.