Skip to content

Commit

Permalink
Add support for custom sqlserver multi_subnet_failover parameter. (#2132
Browse files Browse the repository at this point in the history
)

* Add support for custom sqlservel multi_subnet_failover parameter.

* Make connection parameter string creation more generic.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
jzalucki and pre-commit-ci[bot] authored Jul 17, 2024
1 parent 2293890 commit f13d268
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
16 changes: 16 additions & 0 deletions soda/core/soda/execution/data_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ def __init__(
self.connection = None
self.database: str | None = data_source_properties.get("database")
self.schema: str | None = data_source_properties.get("schema")
self.connection_parameters: dict = data_source_properties.get("connection_parameters", {})
self.table_prefix: str | None = self._create_table_prefix()
# self.data_source_scan is initialized in create_data_source_scan(...) below
self.data_source_scan: DataSourceScan | None = None
Expand All @@ -235,6 +236,21 @@ def __init__(
self.migrate_data_source_name = None
self.quote_tables: bool = data_source_properties.get("quote_tables", False)

def get_connection_parameters_string(self) -> str:
return ";".join(
[
f"{self.get_connection_parameter_key(key)}={self.get_connection_parameter_value(value)}"
for key, value in self.connection_parameters.items()
]
)

def get_connection_parameter_key(self, key: str) -> str:
parts = key.split("_")
return "".join(part.capitalize() for part in parts)

def get_connection_parameter_value(self, value):
return value

def has_valid_connection(self) -> bool:
query = Query(
data_source_scan=self.data_source_scan,
Expand Down
8 changes: 8 additions & 0 deletions soda/sqlserver/soda/data_sources/sqlserver_data_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,12 @@ def handle_datetimeoffset(dto_value):
)

try:
connection_parameters_string = self.get_connection_parameters_string()
self.connection = pyodbc.connect(
("Trusted_Connection=YES;" if self.trusted_connection else "")
+ ("TrustServerCertificate=YES;" if self.trust_server_certificate else "")
+ ("Encrypt=YES;" if self.encrypt else "")
+ (f"{connection_parameters_string};" if connection_parameters_string else "")
+ "DRIVER={"
+ self.driver
+ "};SERVER="
Expand All @@ -149,6 +151,12 @@ def handle_datetimeoffset(dto_value):
except Exception as e:
raise DataSourceConnectionError(self.TYPE, e)

def get_connection_parameter_value(self, value):
if isinstance(value, bool):
return "YES" if value else "NO"

return value

def validate_configuration(self, logs: Logs) -> None:
pass

Expand Down

0 comments on commit f13d268

Please sign in to comment.