Skip to content

Commit

Permalink
Removing the data source name lower case requirement (#2161)
Browse files Browse the repository at this point in the history
* Removing the data source name lower case requirement

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
tombaeyens and pre-commit-ci[bot] authored Sep 11, 2024
1 parent a6f85fe commit 39ff346
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions soda/contracts/soda/contracts/impl/contract_data_source.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import importlib
import logging
import re
import textwrap
from abc import ABC, abstractmethod

Expand Down Expand Up @@ -90,10 +89,6 @@ def __init__(self, data_source_yaml_file: YamlFile):
yaml_helper: yaml_helper = YamlHelper(yaml_file=data_source_yaml_file, logs=self.logs)
self.type = yaml_helper.read_string(self.data_source_yaml_dict, self._KEY_TYPE)
self.name = yaml_helper.read_string(self.data_source_yaml_dict, self._KEY_NAME)
if isinstance(self.name, str) and not re.match("[_a-z0-9]+", self.name):
self.logs.error(
f"Data source name must contain only lower case letters, numbers and underscores. Was {self.name}"
)

self.sql_dialect: SqlDialect = self._create_sql_dialect()

Expand Down

0 comments on commit 39ff346

Please sign in to comment.