New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONFLUENT] Add configuration to disable reprocess files cleanup by v1Cleaner #1045

Merged

sfc-gh-mbobowski merged 9 commits into master from confluentinc-reprocessFilesCleanupCheck

Jan 22, 2025

Contributor

sfc-gh-mbobowski commented Jan 20, 2025

This is the exact copy of #1041

sfc-gh-mbobowski added 2 commits

January 20, 2025 07:11


          [CONFLUENT] Add configuration to disable reprocess files cleanup by v…

4ab2e01

…1Cleaner


          [CONFLUENT] Fix IT

4081ad7

sfc-gh-mbobowski requested a review from a team as a code owner

January 20, 2025 10:54

sfc-gh-dseweryn approved these changes

View reviewed changes

Contributor

sfc-gh-dseweryn left a comment

As a general rule I would prefer to name the param SNOWPIPE_ENABLE_REPROCESS_FILES_CLEANUP so in the code we would not use double negation. Otherwise LGTM


          Disabled -> enabled

063d3fa

Contributor Author

sfc-gh-mbobowski commented Jan 22, 2025

As a general rule I would prefer to name the param SNOWPIPE_ENABLE_REPROCESS_FILES_CLEANUP so in the code we would not use double negation. Otherwise LGTM

Fixed

sfc-gh-mbobowski enabled auto-merge (squash)

January 22, 2025 10:13

sfc-gh-dseweryn reviewed

View reviewed changes

src/main/java/com/snowflake/kafka/connector/internal/SnowflakeSinkServiceV1.java Outdated Show resolved Hide resolved

sfc-gh-mbobowski disabled auto-merge

January 22, 2025 10:23


          Update src/main/java/com/snowflake/kafka/connector/internal/Snowflake…

0e25b8e

…SinkServiceV1.java

Co-authored-by: Dariusz Seweryn <[email protected]>

sfc-gh-dseweryn reviewed

View reviewed changes

src/test/java/com/snowflake/kafka/connector/internal/SinkServiceIT.java Outdated Show resolved Hide resolved


          Update src/test/java/com/snowflake/kafka/connector/internal/SinkServi…

4b691d5

…ceIT.java

Co-authored-by: Dariusz Seweryn <[email protected]>

sfc-gh-dseweryn reviewed

View reviewed changes

src/main/java/com/snowflake/kafka/connector/internal/SnowflakeSinkServiceV1.java Outdated Show resolved Hide resolved

sfc-gh-dseweryn reviewed

View reviewed changes

src/test/java/com/snowflake/kafka/connector/ConnectorConfigValidatorTest.java Outdated Show resolved Hide resolved

sfc-gh-dseweryn reviewed

View reviewed changes

src/test/java/com/snowflake/kafka/connector/ConnectorConfigValidatorTest.java Outdated Show resolved Hide resolved

sfc-gh-mbobowski and others added 4 commits

January 22, 2025 11:30


          Update src/main/java/com/snowflake/kafka/connector/internal/Snowflake…

52cab8e

…SinkServiceV1.java

Co-authored-by: Dariusz Seweryn <[email protected]>


          Update src/test/java/com/snowflake/kafka/connector/ConnectorConfigVal…

24a7f17

…idatorTest.java

Co-authored-by: Dariusz Seweryn <[email protected]>


          Update src/test/java/com/snowflake/kafka/connector/ConnectorConfigVal…

17182e5

…idatorTest.java

Co-authored-by: Dariusz Seweryn <[email protected]>

Fix

74e06b5

sfc-gh-mbobowski merged commit 5b6d9e2 into master

47 of 52 checks passed

sfc-gh-mbobowski deleted the confluentinc-reprocessFilesCleanupCheck branch

January 22, 2025 13:33

sfc-gh-mbobowski mentioned this pull request

Add configuration to disable reprocess files cleanup by v1Cleaner #1041

Closed

12 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet