Snow 1915375 drop copyright header in comments from snowflake repositories #2091
+33
−1,556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into SNOW-1016470-increase-code-coverage-to-at-least-90
…into SNOW-1915375-Drop-copyright-header-in-comments-from-Snowflake-repositories
| /* | ||
| * Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved. | ||
| */ | ||
|
|
||
| /* | ||
| * To change this license header, choose License Headers in Project Properties. |
There was a problem hiding this comment.
Should this comment still be here?
There was a problem hiding this comment.
I think this is a Snowflake-owned file. Could you please confirm if we keep this change or revert.
| @@ -38,7 +38,6 @@ | |||
| * | |||
| * <p>Adapted by Snowflake to return File object when file is spilled to disk. | |||
| * | |||
| * @author Chris Nokleberg | |||
There was a problem hiding this comment.
We shouldn't remove authors from files that are not created by us
src/main/java/net/snowflake/client/jdbc/SnowflakeChunkDownloader.java
Outdated
Show resolved
Hide resolved
| @@ -1,7 +1,3 @@ | |||
| /* | |||
| * Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved. | |||
There was a problem hiding this comment.
You missed an author comment in this file
|
Hi @sfc-gh-astachowski ,Kindly review the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1915375
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.