SNOW-1660591 Remove sensitive encryption info when logging #2077
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-jf
deleted the
SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs
branch
sfc-gh-ext-simba-jf
restored the
SNOW-1660591-Remove-Encryption-Storage-Info-In-Logs
branch
sfc-gh-pfus
reviewed
Feb 25, 2025
src/main/java/net/snowflake/client/jdbc/SnowflakeFileTransferAgent.java
Outdated
Show resolved
Hide resolved
sfc-gh-pfus
approved these changes
Feb 27, 2025
sfc-gh-mhofman
approved these changes
Feb 27, 2025
|
@sfc-gh-mzurek can you have a look? |
sfc-gh-mhofman
requested changes
Feb 27, 2025
| * @param message the message text which may contain encryption material | ||
| * @return Return filtered message | ||
| */ | ||
| public static String filterEncryptionMaterial(String message) { |
There was a problem hiding this comment.
can you please add this function as well to the chain in maskSecrets method?
| @@ -1337,7 +1338,8 @@ private static JsonNode parseCommandInGS(SFStatement statement, String command) | |||
| } | |||
|
|
|||
| JsonNode jsonNode = (JsonNode) result; | |||
| logger.debug("Response: {}", jsonNode.toString()); | |||
|
|
|||
| logger.debug("Response: {}", SecretDetector.filterEncryptionMaterial(jsonNode.toString())); | |||
There was a problem hiding this comment.
can we replace that call with maskSecrets method? we want to replace any possible secrets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1660591
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Parses out the "encryptionMaterial" from the JsonNode before logging