Make snorkel installable as a package #921
Conversation
Workaround for HazyResearch/numbskull#52 https://pypi.org/project/past/ numbskull depends on past https://github.com/HazyResearch/numbskull/blob/52192383b30f2835f5b1e17c6365e2f8c93d97da/numbskull/numbskull.py#L6 Past is installed by future. Builds were failing https://travis-ci.org/HazyResearch/snorkel/jobs/374471391#L892
| @@ -1,4 +0,0 @@ | |||
| [submodule "treedlib"] | |||
.travis.yml
Outdated
|
|
||
| # Install all remaining dependencies as per our README | ||
| - pip install -r python-package-requirement.txt | ||
| - pip install . | ||
| - test -e parser/corenlp.sh || ./install-parser.sh |
There was a problem hiding this comment.
Can we get rid of CoreNLP installation?
There was a problem hiding this comment.
Sounds good! Done in f1dfee2
snorkel/viewer.py
Outdated
| @@ -16,8 +16,7 @@ | |||
| import warnings | |||
| warnings.filterwarnings("ignore", category=DeprecationWarning) | |||
|
|
|||
| HOME = os.environ['SNORKELHOME'] | |||
|
|
|||
| HOME = os.path.abspath(os.path.join(__file__, '..', '..')) | |||
There was a problem hiding this comment.
Need to move .html, etc. files into module?
There was a problem hiding this comment.
Yeah, let's do this in a follow up PR.
README.md
Outdated
| In both cases, the environment can be activated using `conda activate snorkel` and deactivated using `conda deactivate`. | ||
| With older versions of conda, you may have to replace `conda` with `source` in the above commands. | ||
|
|
||
| ### Usage Environment |
There was a problem hiding this comment.
First instructions user should hit is how to install Snorkel as a user (dev environment can come lower in instructions).
There was a problem hiding this comment.
Okay I added a quick start section in c1c0f27
| - git+https://github.com/HazyResearch/snorkel@7eb7076f70078c06bef9752f22acf92fd86e616a | ||
| ``` | ||
| Finally, consider versioning the `numbskull` and `treedlib` pip dependencies by changing `master` to their latest commit hash on GitHub. | ||
|
|
There was a problem hiding this comment.
End of install instructions should emphatically point users to tutorials.
run.sh
Outdated
| @@ -2,9 +2,6 @@ | |||
| source set_env.sh | |||
There was a problem hiding this comment.
Do we need this and set_env.sh? Right now this script installs CoreNLP, which we don't want to do automatically anymore, and launches jupyter.
dhimmel
force-pushed
the
package
branch
4 times, most recently
from
722b670 to
0e0796c
Compare
Switch to absolute imports to ensure installation succeeded
dhimmel
force-pushed
the
package
branch
2 times, most recently
from
c1c0f27 to
7835e79
Compare
dhimmel
force-pushed
the
package
branch
2 times, most recently
from
51eaf31 to
9f15c9d
Compare
|
@ajratner would be great if you can take a look at this PR! |
dhimmel
force-pushed
the
package
branch
2 times, most recently
from
56458f0 to
070ce37
Compare
Remove bootstrap directory which appears to be unused
Closes #920.
Closes #918
Work in progress
snorkel/features/entity_features.pywhich imported treedlib from the submodule.