remove Unpin requirement for the inner stream #358
+134
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
WebSocketStream
requiresUnpin
being implemented for the underlying I/O resource.The aim of this PR is to remove this constrain.
Context
Any underlying I/O streams that work with timeouts logic won't implement
Unpin
.For example:
tokio-io-timeout::TimeoutStream
it does not implementUnpin
.That's because any timer related future over tokio runtime is
!Unpin
.Of course, an easy solution would be to allocate the underlying stream on the heap for pinning (e.g.,
Pin<Box<T>>
). However, that means heap allocation and pointer indirection. Although those drawbacks are probably not really impactful, removingUnpin
requirement will make this library more flexible.On the other hand, removing
Unpin
does not come for free:pin_project
.pin_project
is very very widely spread. It is likely indirectly pulled in anyway.unsafe
code.unsafe
blocks.