Fix missed notification in Mutex example #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
force-pushed
the
notgull/mutex-example
branch
from
65204dc to
5623fc8
Compare
|
Looks good! |
fogti
reviewed
Oct 30, 2024
I forgot to run notify() when I rewrote this example without unsafe code. It looks like it prevents deadlocks in this mutex implementation. I believe this fixes #143. Signed-off-by: John Nunley <[email protected]>
notgull
force-pushed
the
notgull/mutex-example
branch
from
5623fc8 to
4896179
Compare
fogti
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to run notify() when I rewrote this example without unsafe
code. It looks like it prevents deadlocks in this mutex implementation.
I believe this fixes #143. @beckend Can you confirm?