Cancel notification before performing action to improve user experience

smokeballdev · Mar 27, 2019 · 97a5841 · 97a5841
1 parent 06c2822
commit 97a5841
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Plugin.LocalNotifications.Android/LocalNotifications.cs b/src/Plugin.LocalNotifications.Android/LocalNotifications.cs
@@ -74,14 +74,14 @@ public static void ProcessIntent(Intent intent)
             var id = intent.GetStringExtra(LocalNotification.ActionId);
             var action = GetRegisteredActions(actionSetId)?.FirstOrDefault(a => a.Id == id);
 
+            // Cancel notification before performing action to improve user experience
+            CrossLocalNotifications.Current.Cancel(notificationId);
+
             action?.Action(new LocalNotificationArgs
             {
                 Parameter = intent.GetStringExtra(LocalNotification.ActionParameter),
                 TimestampUtc = DateTime.UtcNow,
             });
-
-            // Cancel notification after performing action
-            CrossLocalNotifications.Current.Cancel(notificationId);
         }
 
         internal static IEnumerable<LocalNotificationActionRegistration> GetRegisteredActions(string actionSetId) => _actionRegistrars?.FirstOrDefault(a => a.ActionSetId == actionSetId)?.RegisteredActions;