Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Meteor Beam & Electro Shot #534

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Conversation

Zrp200
Copy link
Contributor

@Zrp200 Zrp200 commented Mar 14, 2023

No description provided.

@Zrp200
Copy link
Contributor Author

Zrp200 commented Mar 14, 2023

The only real possible oversight I can see with this is that this doesn't take into account abilities.

  • It doesn't take into account Simple. The correct behavior here would be to have it raise stat stages by 2.
  • Contrary is not checked, but I doubt that's an actual concern.
  • I am unsure if Sheer Force suppresses the boost.

Are these concerning enough to add checks for them? Otherwise this should be content-complete as a one-line pull request.

Copy link

@lawauditswe lawauditswe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I am unsure if Sheer Force suppresses the boost.

Sheer Force should not suppress the Meteor Beam boost, nor should it boost the damage output.

@Zrp200
Copy link
Contributor Author

Zrp200 commented Feb 7, 2024

  • I am unsure if Sheer Force suppresses the boost.

Sheer Force should not suppress the Meteor Beam boost, nor should it boost the damage output.

In that case it should be good to go (pending the Simple check being added?)

@ShivaD173
Copy link
Contributor

Can you include Electro Shot in this as well?

@Zrp200
Copy link
Contributor Author

Zrp200 commented Feb 23, 2024

@ShivaD173 implemented in 9992afc, that was on my list of things I wanted to do, thanks for reminding me.

I also implemented interactions with the Simple and Contrary abilities while I was at it, and added tests to match.

This should be ready to merge in.

calc/src/mechanics/gen789.ts Outdated Show resolved Hide resolved
calc/src/test/calc.test.ts Outdated Show resolved Hide resolved
Zrp200 and others added 2 commits February 24, 2024 20:17
Neutralizing Gas is not really supported anyway.
@thejetou thejetou changed the title Simulate Meteor Beam's SpA boost Support Meteor Beam & Electro Shot Feb 25, 2024
@thejetou thejetou merged commit ddf9964 into smogon:master Feb 25, 2024
2 checks passed
@thejetou
Copy link
Collaborator

Thanks!

@Zrp200 Zrp200 deleted the meteor-beam branch February 25, 2024 19:39
@Zrp200 Zrp200 restored the meteor-beam branch February 25, 2024 19:47
Celestia74 pushed a commit to Celestia74/eipp-calc that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants