-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Meteor Beam & Electro Shot #534
Conversation
The only real possible oversight I can see with this is that this doesn't take into account abilities.
Are these concerning enough to add checks for them? Otherwise this should be content-complete as a one-line pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I am unsure if Sheer Force suppresses the boost.
Sheer Force should not suppress the Meteor Beam boost, nor should it boost the damage output.
In that case it should be good to go (pending the Simple check being added?) |
Can you include Electro Shot in this as well? |
@ShivaD173 implemented in 9992afc, that was on my list of things I wanted to do, thanks for reminding me. I also implemented interactions with the Simple and Contrary abilities while I was at it, and added tests to match. This should be ready to merge in. |
Co-authored-by: Waleed Hassan <[email protected]>
Neutralizing Gas is not really supported anyway.
Thanks! |
No description provided.