Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmd fix insufficient data after filter #222

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

andrewdavidsmith
Copy link
Collaborator

  • src/common/TwoStatHMM_PMD.cpp: Formatting code
  • src/analysis/pmd.cpp: adding an additional check for sufficient data after filtering bins based on deserts
  • src/analysis/pmd.cpp: changing the min required bins for inference to be 100. It's not clear if this is important because the bins after filtering will be sufficient if the data is good, and if this is a problem, the number of bins will be extremely small

… be 100. It's not clear if this is important because the bins after filtering will be sufficient if the data is good, and if this is a problem, the number of bins will be extremely small
@andrewdavidsmith andrewdavidsmith merged commit 7760e52 into master Jun 4, 2024
1 check passed
@andrewdavidsmith andrewdavidsmith deleted the pmd-fix-insufficient-data-after-filter branch June 4, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant