Replace ember-context #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianoggf
merged commit 6d8c6da
into
address-ember-4-deprecations-part-2
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic ember-context to this addon because, as a dependency, it causes issues with CI (see Slack thread for more details).
Removing the concept of that library in favor of sending data from ancestor components directly down to descendant components was too much effort, and creating something to avoid that also seemed too time-consuming. So, I went with this approach that will allow us to move forward with updating Ember 4, and we can discuss a more adequate solution later on.
The chosen place within the directory of the app was inside
components/polaris-resource-listbecause it was the only component creating the context (and the components within). It can be definitely moved to a more generic place if that is preferred.Please share your thoughts.