Skip to content

Commit

Permalink
Merge branch 'address-ember-4-deprecations-part-2' into replace-ember…
Browse files Browse the repository at this point in the history
…-context
  • Loading branch information
marianoggf committed Jan 11, 2024
2 parents 894a033 + 5e2bd90 commit 99ba6c5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions addon/components/polaris-icon.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ export default class PolarisIcon extends Component.extend(SvgHandling) {
* @public
* @extends emmber-polaris
*/
@computed('sourcePath', 'source')
@computed('_keepFills', 'sourcePath', 'source')
get keepFills() {
// If the value was previously set manually return that value
if (this._keepFills) {
if (this._keepFills !== null && this._keepFills !== undefined) {
return this._keepFills;
}

Expand All @@ -107,7 +107,7 @@ export default class PolarisIcon extends Component.extend(SvgHandling) {
}
set keepFills(value) {
// Update the internal state instead of directly setting the computed property
this._keepFills = value;
this.set(this, '_keepFills', value);
}

/**
Expand Down

0 comments on commit 99ba6c5

Please sign in to comment.