-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into address-ember-4-deprecations-part-2
- Loading branch information
Showing
9 changed files
with
18,266 additions
and
14,161 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/usr/bin/env sh | ||
. "$(dirname -- "$0")/_/husky.sh" | ||
|
||
yarn lint-staged | ||
pnpm lint-staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# these settings allow us to be good stewards of the ecosystem | ||
# end-consumers can flip these settings in their own projects, | ||
# but library authors should not allow for less-than-strictest | ||
# behavior. | ||
# | ||
# For more information: https://pnpm.io/npmrc | ||
auto-install-peers=false | ||
resolve-peers-from-workspace-root=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,25 +2,25 @@ | |
|
||
## Installation | ||
|
||
* `git clone <repository-url>` | ||
* `cd ember-smile-polaris` | ||
* `yarn install` | ||
- `git clone <repository-url>` | ||
- `cd ember-smile-polaris` | ||
- `pnpm install` | ||
|
||
## Linting | ||
|
||
* `yarn lint` | ||
* `yarn lint:fix` | ||
- `pnpm lint` | ||
- `pnpm lint:fix` | ||
|
||
## Running tests | ||
|
||
* `ember test` – Runs the test suite on the current Ember version | ||
* `ember test --server` – Runs the test suite in "watch mode" | ||
* `ember try:each` – Runs the test suite against multiple Ember versions | ||
- `ember test` – Runs the test suite on the current Ember version | ||
- `ember test --server` – Runs the test suite in "watch mode" | ||
- `ember try:each` – Runs the test suite against multiple Ember versions | ||
|
||
## Running the dummy application | ||
|
||
* `ember serve` | ||
* Visit the dummy application at [http://localhost:4200](http://localhost:4200). | ||
- `ember serve` | ||
- Visit the dummy application at [http://localhost:4200](http://localhost:4200). | ||
|
||
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/). | ||
|
||
|
@@ -31,8 +31,8 @@ For more information on using ember-cli, visit [https://ember-cli.com/](https:// | |
git remote add upstream --no-tags [email protected]:smile-io/ember-polaris.git | ||
|
||
``` | ||
**NOTE:** Make sure you use `--no-tags` when adding upstream so that fetching from upstream does not pull in `ember-polaris`'s tags and overwrite this addon's own tags. | ||
|
||
**NOTE:** Make sure you use `--no-tags` when adding upstream so that fetching from upstream does not pull in `ember-polaris`'s tags and overwrite this addon's own tags. | ||
|
||
### Merging upstream changes | ||
|
||
|
@@ -43,4 +43,5 @@ git checkout master; | |
git checkout -b upstream-merge; | ||
git merge ember-polaris-master --no-ff; | ||
``` | ||
|
||
On the last step among other possible conflicts, you'll notice a conflict in the `package.json` file for the package information. Ensure you keep `ember-smile-polaris'` info as is & resolve any other conflicts on a case by case basis. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.