Fixed silent error occurrence on 200 http status code (ExceptionWhileProcessing query error) #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #144
This problem occurs on partially flushed response to the client with 200 status code with further ClickHouse exception.
All details in StatementTest::testIsErrorWithOkStatusCode
I've used preg_match instead of stripos (suggested in #144) because regexes precompiles and further calls are much cheaper (about 10 times in my tests of clickhouse error regex). Also stripos speed only 30% faster (and less) than first call of preg_match on string from 10MB to 1000MB.