Filter out empty events #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hendrik1704
requested changes
Nov 20, 2024
There was a problem hiding this comment.
Do I understand your comment correctly? If you load a file with 5 events and then filter everything out with the multiplicity_cut for example, then the number of events is 0, num_outputs_per_event is an empty list and the particle list contains only one empty list?
Yes |
Hendrik1704
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to sloppy implementation in #296 by @LucasConstantin and an at least equally sloppy review by myself, there were unused variables which didn't handle the case of inverted cut boundaries. Upon fixing and testing this, I noticed that we do not handle correctly empty events when filtering, namely we do not remove them. The multiplicity cut event removal was not done for constructors, only for manual filtering afterwards. This opened Pandora's box.
In the current state of affairs, I keep events which are fed into the constructor empty, and only remove such which are emptied by filtering. In future, this should maybe be customisable.