Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically typing SPARKX #277

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Statically typing SPARKX #277

merged 3 commits into from
Oct 24, 2024

Conversation

RenataKrupczak
Copy link
Collaborator

No description provided.

NGoetz
NGoetz reviewed Aug 26, 2024
View reviewed changes
src/sparkx/CentralityClasses.py Show resolved Hide resolved
src/sparkx/EventCharacteristics.py Outdated Show resolved Hide resolved
src/sparkx/Histogram.py Show resolved Hide resolved
src/sparkx/Jackknife.py Show resolved Hide resolved
src/sparkx/Utilities.py Show resolved Hide resolved
NGoetz
NGoetz approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@NGoetz NGoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now, but it will require a rebase. I guess to minimize pain, we merge this only after the other PR is merged. There should be normally no conflict, but something is going on with the formatter. Let's clarify this first.
Good job!

@NGoetz
Copy link
Member

NGoetz commented Oct 9, 2024

To minimise the merge conflicts, let's apply the formatter and push, and then see what is left.

@RenataKrupczak RenataKrupczak force-pushed the krupczak/statical_typing branch from 6630cfe to eeef181 Compare October 24, 2024 15:59
Hendrik1704
Hendrik1704 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Hendrik1704 Hendrik1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. The statical typing test is still failing. Something to work on.

@Hendrik1704 Hendrik1704 merged commit bcf78fb into sparkx_devel Oct 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGoetz NGoetz NGoetz approved these changes

@Hendrik1704 Hendrik1704 Hendrik1704 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RenataKrupczak @NGoetz @Hendrik1704