Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Histogram and CentralityClasses #185

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add tests for Histogram and CentralityClasses #185

merged 4 commits into from
Feb 14, 2024

Conversation

Hendrik1704
Copy link
Collaborator

This adds unit tests for the Histogram class and fixes issue #184. I added another raise ValueError in the function to scale histograms.

@Hendrik1704 Hendrik1704 added the tests Something related to the pytests label Feb 14, 2024
@Hendrik1704 Hendrik1704 added this to the SPARKX 1.2 milestone Feb 14, 2024
@Hendrik1704 Hendrik1704 requested a review from NGoetz February 14, 2024 15:12
@Hendrik1704 Hendrik1704 self-assigned this Feb 14, 2024
NGoetz
NGoetz approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@NGoetz NGoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR, but have a look at both comments I added.

tests/test_CentralityClasses.py Show resolved Hide resolved
tests/test_Histogram.py Outdated Show resolved Hide resolved
@Hendrik1704 Hendrik1704 merged commit 5e685bf into sparkx_devel Feb 14, 2024
1 check passed
@Hendrik1704 Hendrik1704 deleted the roch/add_tests branch February 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGoetz NGoetz NGoetz approved these changes

Assignees

@Hendrik1704 Hendrik1704

Labels
tests Something related to the pytests
Projects
None yet
Milestone
SPARKX 1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Hendrik1704 @NGoetz