Add particle tests and fix nan checks bug #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hendrik1704
added
bug
|
I opened issue #174 to document one of the bugs I solved with the latest push. This is now also reflected in the issue number in the CHANGELOG. |
nilssass
reviewed
Dec 20, 2023
nilssass
reviewed
Dec 20, 2023
nilssass
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs in the Particle class. Today I wanted to complete the tests for the class and I realized, that we tested in all functions with
self.x == np.nan, which should benp.isnan(self.x).I fixed this now in this PR and added test functions for all Particle class functions.
@NGoetz @nilssass Do we want to release a 1.1.1 version to fix this?