Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing for Rocky Linux with integration test, and distinguish rebench return codes #282

Merged
merged 4 commits into from
Jan 26, 2025

Conversation

smarr
Copy link
Owner

@smarr smarr commented Jan 26, 2025

In preparation of #281, this PR adds a Rocky Linux integration test.
Most of our use is on Ubuntu, though, some people use a RHEL-like Linux.
Thus, the key chain is to add CI testing.

However, we also:

  • use now different exit codes for different ReBench failure modes
  • check in tests whether the CPU info is present. it's not present on Rocky Linux on GitHub Actions
  • shielding can also return a string

@coveralls
Copy link

Coverage Status

coverage: 84.488% (-0.01%) from 84.499%
when pulling 23c3670 on test-on-rocky
into d24a4c4 on master.

@smarr smarr merged commit 3b0bffe into master Jan 26, 2025
12 of 14 checks passed
@smarr smarr deleted the test-on-rocky branch January 26, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants