Make rebench-denoise more robust to absent tools and running as root with a user-level installation #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- give more useful errors when tools are not available and how to work around it - don’t error when cset not available Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- preserve PYTHONPATH across sudo for denoise - adapt tests to handle the PYTHONPATH that’s now set Signed-off-by: Stefan Marr <[email protected]>
The main goal here is to have denoise require the fewest possible dependencies when running under root, which avoids issues with PYTHONPATH, dependencies being installed by the user, and generally to minimize the capabilities of denoise. - denoise_client now provides the interface for rebench to access denoise - minor refactorings to avoid circular dependencies - move getting number of cores to denoise_client to avoid dependency on cpuinfo inside root - cache number of cpu cores to avoid requesting them repeatedly which is very expensive Signed-off-by: Stefan Marr <[email protected]>
- remember when we didn’t find the path Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Since there are user-visible changes around the denoise interface and behavior, I am bumping the version. Signed-off-by: Stefan Marr <[email protected]>
smarr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perhaps most important issue this PR addresses is rebench-denoise being used with
sudobut root not having access to any of the installed packages and dependencies.To avoid the issue in the first place, we split the denoise implementation and move all use of packages into the part that's only used from rebench.
We also set PYTHONPATH so that denoise finds itself.
More minor improvements include:
This resolves #251.