Add support for ReBenchDB API Version 2 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extract convert_data_to_api_format - extract convert_data_to_json method - add a test for the JSON rendering - this is really mostly for me to design the new API
ReBenchDB will send a header on an OPTIONS request advertising that version 2.0.0 of the API is supported. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
- add testing with HTTP 400 error code Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReBenchDB is going to introduce a new API version 2, which expects all measurement values as arrays of iterations instead of objects. This should be more efficient in memory and on the wire.
Relevant PR: smarr/ReBenchDB#100
This PR also fixes issues around HTTP error handling. HTTP 400 status code will now avoid retries since it indicates that the made request is not supported.