Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions and Avoid GIL Issues and Races with MockHTTPServer #235

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

smarr
Copy link
Owner

@smarr smarr commented Feb 18, 2024

  • GitHub Actions resulted in deprecation warnings, which are now resolved
  • reenable testing on PyPy, and test on Python 3.12
  • make sure that Python gave the MockHTTPServer a chance to run and process the requests

- yield the GIL, and sleep a bit
- then shutdown proactively and this way synchronize execution
- keep fallback in case of error

Signed-off-by: Stefan Marr <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 83.966% (+0.5%) from 83.42%
when pulling 698cdcd on gha
into fd8fa6b on master.

@smarr smarr merged commit 21bd647 into master Feb 18, 2024
12 checks passed
@smarr smarr deleted the gha branch February 18, 2024 20:02
smarr added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reenable testing on PyPy on GitHub Actions once the PyYAML issue is resolved
2 participants