fix tests

smalot · Nov 4, 2016 · 161b438 · 161b438
1 parent 3d5b91b
commit 161b438
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/src/Smalot/PdfParser/Header.php b/src/Smalot/PdfParser/Header.php
@@ -53,8 +53,8 @@ class Header
     protected $elements = null;
 
     /**
-     * @param Element[] $elements List of elements.
-     * @param Document $document Document.
+     * @param Element[] $elements   List of elements.
+     * @param Document  $document   Document.
      */
     public function __construct($elements = array(), Document $document = null)
     {
@@ -99,7 +99,7 @@ public function getElementTypes()
      */
     public function getDetails($deep = true)
     {
-        $values = array();
+        $values   = array();
         $elements = $this->getElements();
 
         foreach ($elements as $key => $element) {
@@ -112,7 +112,7 @@ public function getDetails($deep = true)
                     $values[$key] = $element->getDetails();
                 }
             } elseif ($element instanceof Element) {
-                $values[$key] = (string)$element;
+                $values[$key] = (string) $element;
             }
         }
 
@@ -175,9 +175,9 @@ protected function resolveXRef($name)
     }
 
     /**
-     * @param string $content The content to parse
+     * @param string   $content  The content to parse
      * @param Document $document The document
-     * @param int $position The new position of the cursor after parsing
+     * @param int      $position The new position of the cursor after parsing
      *
      * @return Header
      */

diff --git a/src/Smalot/PdfParser/Tests/Units/Header.php b/src/Smalot/PdfParser/Tests/Units/Header.php
@@ -118,13 +118,9 @@ public function testGet()
         $this->assert->object($header->get('SubType'))->isInstanceOf('\Smalot\PdfParser\Element\ElementName');
         $this->assert->object($header->get('Font'))->isInstanceOf('\Smalot\PdfParser\Page');
         $this->assert->object($header->get('Image'))->isInstanceOf('\Smalot\PdfParser\Element\ElementMissing');
+        $resources = $header->get('Resources');
 
-        try {
-            $resources = $header->get('Resources');
-            $this->assert->boolean(true)->isEqualTo(false);
-        } catch (\Exception $e) {
-            $this->assert->exception($e)->hasMessage('Missing object reference #8_0.');
-        }
+        $this->assert->variable($resources)->isNull();
     }
 
     public function testResolveXRef()
@@ -138,11 +134,12 @@ public function testResolveXRef()
 
         $this->assert->object($header->get('Font'))->isInstanceOf('\Smalot\PdfParser\Object');
 
+        $header=$header->get('Resources');
         try {
-            $this->assert->object($header->get('Resources'))->isInstanceOf('\Smalot\PdfParser\Element\ElementMissing');
+            $this->assert->variable($header)->isInstanceOf('\Smalot\PdfParser\Element\ElementMissing');
             $this->assert->boolean(true)->isEqualTo(false);
         } catch (\Exception $e) {
-            $this->assert->exception($e)->hasMessage('Missing object reference #8_0.');
+            $this->assert->variable($header)->isNull();
         }
     }
 }