silence warnings (#790)

slsdetectorgroup · Jul 26, 2023 · 7383b13 · 7383b13
1 parent d5ce039
commit 7383b13
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -1,25 +1,31 @@
 ---
 Checks:          '*, 
+                    -altera-*,
                     -android-cloexec-fopen,
                     -cppcoreguidelines-pro-bounds-array-to-pointer-decay, 
                     -cppcoreguidelines-pro-bounds-pointer-arithmetic, 
                     -fuchsia*,
                     -readability-else-after-return,
                     -readability-avoid-const-params-in-decls,
+                    -readability-identifier-length,
                     -cppcoreguidelines-pro-bounds-constant-array-index,
                     -cppcoreguidelines-pro-type-reinterpret-cast,
                     -llvm-header-guard,
+                    -modernize-use-nodiscard,
+                    -misc-non-private-member-variables-in-classes,
                     -readability-static-accessed-through-instance,
                     -readability-braces-around-statements,
+                    -readability-isolate-declaration,
+                    -readability-implicit-bool-conversion,
+                    -readability-identifier-length,
+                    -readability-identifier-naming,
                     -hicpp-signed-bitwise,
                     -hicpp-no-array-decay, 
                     -hicpp-braces-around-statements,
                     -google-runtime-references, 
                     -google-readability-todo, 
                     -google-readability-braces-around-statements,
                     -modernize-use-trailing-return-type,
-                    -readability-isolate-declaration,
-                    -readability-implicit-bool-conversion,
                     -llvmlibc-*'
 
 HeaderFilterRegex: \.h

diff --git a/slsSupportLib/include/sls/sls_detector_defs.h b/slsSupportLib/include/sls/sls_detector_defs.h
@@ -30,7 +30,8 @@
 // C includes
 #include <stdint.h>
 #endif
-
+//Need macros for C compatibility
+//NOLINTBEGIN(cppcoreguidelines-macro-usage)
 #define BIT32_MASK  0xFFFFFFFF
 #define MAX_RX_DBIT 64
 
@@ -79,7 +80,7 @@
 #define DEFAULT_STREAMING_TIMER_IN_MS 500
 
 #define NUM_RX_THREAD_IDS 9
-
+//NOLINTEND(cppcoreguidelines-macro-usage)
 #ifdef __cplusplus
 class slsDetectorDefs {
   public: