Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cheerio from 0.22.0 to 1.0.0-rc.10 #4

Closed
wants to merge 1 commit into from

Conversation

fargito
Copy link

@fargito fargito commented Apr 5, 2022

Hello @slorber and thanks for this package.

I noticed a security warning on github security advisories concerning nth-check, which is a direct dependency of cheerio.

This PR fixes this security issue by bumping cheerio to its latest version, which seems to be widely used according to the npm stats.

Thanks a lot 😉

@tnir
Copy link

tnir commented May 2, 2022

I need this too!!

@Josh-Cena
Copy link

We definitely need to do this. In fact, we can completely get rid of cheerio, because it's only used with the crawl option, which Docusaurus doesn't depend on.

We are also waiting for the @Docusaurus org so we can transfer this repo there, after which this package can probably be better maintained. See facebook/docusaurus#6246

@slorber
Copy link
Owner

slorber commented Jun 1, 2022

cheerio is removed in refactor #2

@slorber slorber closed this Jun 1, 2022
@tnir
Copy link

tnir commented Jun 1, 2022

@slorber Thanks for merging #2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants