fix: fail safely if unable to get player status (Media Control) #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In come cases where there exists a registered MPRIS player that
doesn't have support for playerstatus, safeeyes errors and doesnt
launch a break when the Media Control plugin is enabled.
This patch adds a check to the mediacontrol plugin that checks
if "PlaybackStatus" cached_property is not None, and only then attempts
to get media playing status.
Steps to reproduce:
Error:
Expected Behaviour:
Doesn't crash