Fix bug in Device.setPollInterval() #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## pre-release #984 +/- ##
===============================================
+ Coverage 29.55% 30.05% +0.49%
===============================================
Files 65 65
Lines 6641 6641
Branches 1014 1014
===============================================
+ Hits 1963 1996 +33
+ Misses 4524 4488 -36
- Partials 154 157 +3 ☔ View full report in Codecov by Sentry. |
slacrherbst
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where
Device.setPollInterval()was making an obsolete call to set the poll interval of each variable.Documentation has also been updated to make note of the API change when setting Variable poll interval in Rogue v6.
Related
Need to merge #983 first.