ENH: Add Pyside6 compatible UI file compilation #1163
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t6 enum support The need for inheritance was b/c when an enum gets written to a ui file by designer, its in the form of <widget class name>::<enum value> (ex='PyDMLabel::STRING'). On loading the ui file, unless the widget class had subclassed the enum class it would not be able to find the definition of the enum. The issue with subclassing the enum is: in qt6 enums must inherit from python Enum (ex = class MyNewEnum(Enum)), and these classes can not be inherited from. So instead of inheriting the enum we can just re-declare the values of the enum in the class itself.
To support enums as part of widget-classes in pyside6, and to have them work in designer, requires a bit different implementation than in pyqt5: https://doc.qt.io/qtforpython-6/PySide6/QtCore/QEnum.html Also switch from 'Q_ENUMS' -> 'Q_ENUM', since its a newer verison of enum macro for pyqt5.
and fix few small typos in comments
The pyqt5 uic lib seems to be replaced by cmdline tool in pyside6, https://doc.qt.io/qtforpython-6/tools/pyside-uic.html.
nstelter-slac
force-pushed
the
pyside6_ui_compilation
branch
from
724093c to
7269b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should be reviewed later, since the diff should be clear when my previous patches merge in