Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new DNS config options #879

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Document new DNS config options #879

merged 1 commit into from
Jul 10, 2023

Conversation

johnmaguire
Copy link
Collaborator

@johnmaguire johnmaguire commented May 18, 2023 •
edited
Loading

Fixes #910.

Documents the config options added in #796.

@wadey wadey added this to the v1.8.0 milestone May 18, 2023
@wadey wadey added the documentation Improvements or additions to documentation label May 18, 2023
@johnmaguire johnmaguire mentioned this pull request Jun 28, 2023
Closed
@IanVS
Copy link
Collaborator

IanVS commented Jul 3, 2023 •
edited
Loading

Should this also be documented in https://github.com/DefinedNet/nebula-docs?

Edit: just found DefinedNet/nebula-docs#100 which is tracking that work.

jasikpark
jasikpark approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the correctness of these docs, but they look good and seem like they should be correct

lgtm

@johnmaguire johnmaguire merged commit 7e380bd into master Jul 10, 2023
@johnmaguire johnmaguire deleted the document-dns branch July 10, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasikpark jasikpark jasikpark approved these changes

@wadey wadey wadey approved these changes

Assignees
No one assigned
Labels
cla:signed documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Docs: Document IPv4/IPv6 network toggle for DNS queries
4 participants
@johnmaguire @IanVS @wadey @jasikpark