types(test): add a test to not mix up built-in node MessageEvent type
#2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with Slack MessageEvent type (relates to #2020)
filmaj
added
semver:patch
tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2022 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 37 37
Lines 9946 9946
Branches 633 633
=======================================
Hits 9199 9199
Misses 747 747
Flags with carried forward coverage won't be shown. Click here to find out more. |
WilliamBergamin
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we also have an identically-named Slack
MessageEventtype. This is a test that relates to #2020 and augments #2021.I've confirmed that this test fails without the fix from #2021