Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prompt for channel conversation summarization #48

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

djjimba
Copy link
Contributor

@djjimba djjimba commented Feb 18, 2025

Type of change (place an x in the [ ] that applies)

  • New sample
  • New feature
  • Bug fix
  • Documentation

Summary

My initial intent was to fix typos conversaton, and cath in the prompt for channel conversation summarization,
but went ahead and updated it overall without changing the intent of the prompt.

Requirements (place an x in each [ ] that applies)

  • I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
  • I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
  • I've read and agree to the Code of Conduct

Initial intent was to fix typos conversaton, and cath.
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @djjimba! 👋 Sharp eye with this PR, it's always appreciated 👁️‍🗨️

I noted one nuance of Slack API wording, but that's a small change so let's merge this after for a nice improvement 🎉

@zimeg zimeg added the bug Something isn't working label Feb 18, 2025
@zimeg zimeg merged commit 0cc9e9d into slack-samples:main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants