Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/archon droplet #223

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Feature/archon droplet #223

wants to merge 8 commits into from

Conversation

vespos
Copy link
Collaborator

@vespos vespos commented Jan 23, 2025

Add support for droplet for archon detector.

In doing so, we implement a new type of DetObject for LCLS-II: ImageObjectm, which will make use of det.raw.image to get the data. This new class takes care to update all parameters (ped, gain, ...) to image shape so that DetObjectFunc can run seamlessly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see why json is now imported.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use it to print the droplet argument dictionary nicely to the log. This makes it easier to read the rather intricate dictionary:
print(json.dumps(d2p_args[detname], indent=4))

Copy link
Collaborator

@silkenelson silkenelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. We'll have to keep an eye out wrt to all the detectors that will come with MFX - e.g. the common_mode choices should not be limited to 0&30 although I may not have seen why we do that. This is likely doing the wrong thing for the UED Quad already.

@vespos
Copy link
Collaborator Author

vespos commented Jan 27, 2025

Yes, we can expand the common mode settings as needed for future / new detectors.

@vespos
Copy link
Collaborator Author

vespos commented Jan 28, 2025

I have deployed it ro RIX, keeping it as a draft until I get some feedback from the users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants